wokket/rust-hl7

code simplification

Closed this issue · 2 comments

yatesco commented

(just a minor nit ;-):

rust-hl7/src/message.rs

Line 214 in e1b8456

// TODO: This `foreach s { s? }` equivalent seems unrusty.... find a better way
can be reduced to let segments: Result<Vec<Segment>, E> = possible.into_iter().collect()?;

:-)

wokket commented

Love it! Given I don't even have rust installed at the moment, I'm very open to a small PR :)

Are you using this library for anything interesting?

  • 😄1
yatesco commented

I'm not actually using it as we wrote our own parser using nom. I was idly musing how to query into the message and thought I'd search for prior art, and noticed your TODO :-)