Add pypiwin32 as dependency on setup.py
evandrocoan opened this issue · 9 comments
If I understand the linked issue correctly, I need to check if the pywin32 module can be imported and if not, pypiwin32 should be installed?
Or should it always have pypiwin32 as a dependency?
Also, it should be noted that the concurrent-log-handler uses one of the portalocker forks (this project was created in an attempt to unify them). Even if I fix this here it won't help for that project unless it switches from using concurrent_log_handler.portalocker to portalocker
pypiwin32 and pywin32 are the same extension for Python for Windows, however pypiwin32 is an old version (220) of pywin32 extension (deprecated and not updated anymore) and pywin32 is the latest version (222).
However on the latest version of pywin32, they introduced a regression which breaks the installation:
- mhammond/pywin32#1151 pypiwin32 version 222 - Failed to be installed
Even if I fix this here it won't help for that project unless it switches from using concurrent_log_handler.portalocker to portalocker
Yes, I was just pointing out it here so this problem does not happen for your direct users, because I lost some time fighting against this import error when running tox on Python 2.7 and 3.4
Thanks for the help, fixed on develop :)
pypiwin32 and pywin32 are the same extension for Python for Windows, however pypiwin32 is an old version (220) of pywin32 extension (deprecated and not updated anymore) and pywin32 is the latest version (222).
@evandrocoan , I read similar comment from this StackOverflow Q&A too.
So, why didn't you just suggest @wolph to use pywin32 rather than pypiwin32 as a dependency? What gives?
Because it was not working with my project which support older versions of python.
@evandrocoan I've switched out pypiwin32 for pywin32`. If there are issues with specific environments, can you tell me which ones so I can make an exception for those?
Sure! I will get back when/if some problem show up.