woodpecker-ci/woodpecker

Improve linter output for `secret:` deprecation

Closed this issue · 2 comments

pat-s commented

Component

web-ui

Describe the bug

If one has secrets: specified in WP next instead of using environment: SECRET from_secret: etc, the following linter message is shown

image

This is quite confusing.

I'd argue that

  • The first two ones should be hidden
  • The wording of the last one should be changed to something like users can directly understand and act on: "Using deprecated secrets: notation, please use define the secret in environment: instead using the from_secret: syntax

Steps to reproduce

.

Expected behavior

.

System Info

next

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
zc-devs commented

Using

Using by whom? Woodpecker won't process it, if I understand correctly.

deprecated secrets: notation please use define the secret in environment: instead using the from_secret: syntax

When it was deprecated, it was like you proposed. Now (in 3.0) it is not allowed.

6543 commented

-> #4363