woodpecker-ci/woodpecker

Let backend set network mode

Opened this issue · 3 comments

6543 commented

In my mind ... the compiler sets the network mode ... and makes asumption it does not know ...

So we have to check how networkmode is currently handled ... and refactor to move tha logic out from the frontemd

woodpecker/pipeline/frontend/yaml/types/container.go

Line 64 in 05e3559

NetworkMode string `yaml:"network_mode,omitempty"`

6543 commented

E.g. if important to change -> dedicated backend option

qwerty287 commented

This is set nowhere. If you have network privileges, you can set it in your YAML, otherwise it remains empty.

qwerty287 commented

@6543 does my comment is enough so we can close it? Or what's your intention with the issue?