workloads/regional-aws-deployment

create base deployment

Closed this issue · 1 comments

Hey @justinretzolk,

following our chat, allow me to describe a few things that I think this repository should be able to do.

The TL,DR is that Terraform Cloud will apply the files in this directory to all regional TFC workspaces.

As such, the input "contract" is key.

  • VPC should default to the default VPC of that AWS region.

Consider using a local value for this to add some logic in the sense of "if var.vpc_id is not set, then fall back to the ID retrieved from data.aws_vpc

  • EC2 should not have a default value for instance type or AMI
  • EC2 must accept user-data for deployment
  • ASG should default to 0 instances

For easy testing, I'd suggest creating examples/basic which sets all required variables. Feel free to check the Azure-equivalent of this at https://github.com/workloads/regional-azure-deployment

This was fixed in #19 and improved in #20