Unknown directory type causes deserialization failure

Question

Unknown directory type causes deserialization failure

Closed this issue 3 years ago · 5 comments

We are getting the following error:

java.security.SignatureException: Invalid signature: Cannot deserialize value of type `com.workos.directorysync.models.DirectoryType` from String "onelogin scim v2.0": not one of the values accepted for Enum class: [...]

It seems like it's probably bad design to use a java enum for a dynamic field like this in a client library since java enums aren't able to represent unknown values.

Answer 1 · 2022-02-17T19:46:48.000Z

Obviously a short term fix is to just add the enum variant for onelogin, but I think you should consider making this field a String.

Answer 2 · 2022-02-17T20:01:15.000Z

Another idea is to use one of these techniques: https://blog.wpanas.eu/posts/best-way-to-handle-unkown-enum-values-using-jackson/

Answer 3 · 2022-02-17T21:56:29.000Z

Thanks @singron for the report. For the time being we can add the missing type to unblock you.

The team and I will discuss potential approaches to make this more resilient in the future.

Answer 4 · 2022-02-17T22:27:22.000Z

v1.2.1 has been published: https://search.maven.org/artifact/com.workos/workos/1.2.1/jar

Answer 5 · 2022-07-14T19:26:44.000Z

Any update on this? The same thing happened again.