[BUG] Jekyll site has inconsistent max-width property due to all-contributors section
ankush opened this issue · 5 comments
Jekyll site has inconsistent max-width property due to all-contributors section
** Steps to reproduce the behaviour:**
- Go to jekyll site https://world-class.github.io/REPL/
- Scroll down to bottom.
- Wait till your OCD kicks in.
Expected behaviour
Consistent max-width throughout page.
Screenshots
Website looks odd on phone, we need to fix that too
🔜
Yes, again it's not that it's more "broken" than before (in fact, I think it's better), but it didn't get fixed either. Still, you came up with the right approach so that's pretty useful in and of itself!
So, a single-character fix should have solved this issue 🎉 : 8001fac
It looks much better on mobile too. I didn't do any kind of extensive testing for this of course. Let me know what you think: maybe we will be able to close this issue and #148, although that other one could also live on if we plan on actually improving something at some point 😄.
Ah. I should've searched for this config before modifying css 🤦
Anyhoo. Checked recent commit. Now it looks MUCH better and far more readable than before. Especially the detail tags. We can close this one, let other one be open so if someone else wants to contribute better design they can propose 😉
I should've searched for this config before modifying css
No! in fact that was a useful change that you did and at the same time I saw how CSS was supposed to be modified so I ended up making a little change to the details tag while I was there. Maybe the :hover effect was a bit much, but hey, if it bothers someone else enough, they might just get the necessary motivation to go ahead and fix it by themselves 😁.