world-federation-of-advertisers/planning-evaluation-framework

Including universe size in ReachPoint

Closed this issue · 1 comments

amiragha commented

planning-evaluation-framework/src/models/reach_point.py

Line 27 in 49e259f

def __init__(

I think the concept of ReachPoint is ambiguous without defining the universe size. Including the universe size information in a ReachCurve can help keep the numerical calculation and modeling at the level of the normalized reach. It would be more helpful to work with normalized reach especially for simulation and research purposes.

Let me know what you think.

jiayu-google commented

Makes great sense to me. Recommendations accepted. Please have another round of review of PR105!