worldbank/iefieldkit

ieduplicates: make sure command works with cd

Closed this issue · 7 comments

ieduplicates: make sure command works with cd

😕 I honestly think this is a Stata practice we should not allow. But I will be ok with being outvoted on this one.

I don't think this is a Stata-specific practice, but I agree it's a bad one.
Still, if people want to use it, I think it would be best to just throw a warning with a link to a wiki page explaining why they shouldn't and still let them.

I agree that working with relative file paths is not a Stata specific practice. I use it all the time in python. But in Stata relative file paths are implemented in a very error prone way, so making relative file paths a Stata practice is a bad practice IMHO. But you are in charge of this product so it is your call.

I see what you mean now by a bad Stata practice. Now that I have added a section to the Wiki explaining why not to do this, so I link the error message to it, I'm ok with not allowing it, and saying explicitly why it is not allowed.

This is solved now, right? In the sense that it is still not allowed but an helpful error message is shown?

Right!

This is now published.