worldbank/ietoolkit

`iedorep`: unclosed comment blocks at end of do-file cause errors

luisesanmartin opened this issue · 4 comments

This do-file (dofile.do):


foreach letter in a b c {
  display "`letter'"
}
/*
Comments here.  Note that comment section is not closed

generates the following error when used as an input in iedorep "dofile.do":

. iedorep dofile.do
 
Processing: dofile.do
Entering dofile.do run....
Done with dofile.do!
variable Path not found
r(111);

. 

note that I tried this with the current development version (dev-iedorep). Didn't check if it also happened in the stable version

also, I don't know if it gives hints about the issue but I noticed that sometimes the output is returned as:

. iedorep dofile.do
file C:\Users\wb532468\AppData\Local\Temp\ST_2abc_000004.tmp not found
 
Processing: dofile.do
Entering dofile.do run....
Done with dofile.do!
variable Path not found
r(111);

. 

note the file not found... line, it doesn't show every time and I don't know why sometimes it's there. Not something that needs correction in my opinion, but I'm flagging it in case it gives hints about the issue

This could be handled since comment status is tracked on Line 271-2. Does lint check for unclosed comment or loop?

Does lint check for unclosed comment or loop?

no, but it's something we should add. I'm creating an issue on it