Bumping supported version
szepeviktor opened this issue · 8 comments
When a plugin author bumps supported core version in readme.txt we get "Checksum does not match"
+1 My test results are returning Checksum does not match on 3 plugins' readme.txt files.
@szepeviktor @shawnhooper Can you share which plugins are impacted by this?
@schlessera Maybe we should only Warning: when readme.txt differs?
Maybe we should only Warning: when readme.txt differs?
Yes.
If a plugin author knows of this trick then readme will change outside releases.
Can you share which plugins are impacted by this?
For example wp-postratings and classic-smilies
Can you share which plugins are impacted by this?
advanced-custom-fields, duplicate-post, and google-drive-embedder on the site I tested with.
@eriktorsner had included the concept of "soft changes" in his implementation: https://github.com/eriktorsner/wp-checksum/blob/6ed1a5ea5fb77f418a4abaf27795626ade75c863/src/PluginChecker.php#L22-L24
I'd suggest using the same approach, ignoring soft changes, while optionally allowing strict checks through an additional parameter.
The "soft change" functionality was now added.
readme.txt changes should now be ignored unless you specify the --strict flag.
Thank you.