Binaries Data
Closed this issue · 7 comments
There is an issue with binaries data. Them are removed in b817c69
Are no longer necessary?
Because assignment and logic remains https://github.com/inpsyde/search-and-replace/blob/master/inc/Database/Exporter.php#L443
I think is an mistake. In the tests was ok, no problems, but no unittests that show us the problem in the deep.
The point to change this was this post https://medium.com/websec/wordpress-and-recursive-unserialize-5518b124b23b and his contact. But I changed only short and fast this function and get a lot of errors, so that I was not in deep dive inside the source.
I'll add again the binaries, but may you have a look at the recursive_unserialize_replace ? I'm not sure about the issue with the serialized data.
Have you this function inside the tests? This function was the point that we need an deep test about s/r for serialized data.
Yup, here https://github.com/inpsyde/search-and-replace/blob/master/tests/UnitTests/Database/ReplaceTest.php#L348 with a data provider, so I can add more strings.
Great, again and again, it is great to see the work. ❤️
Reintroduced the binaries data. I close this one and create a new regarding the serialized issue, so we have a place where discuss that in order to prevent the bug will be introduced again.