[bug] - Property/Text : nl2br
nlemoine opened this issue · 1 comments
nlemoine commented
What happened
Using a regular text field:
papi_property( [
'title' => 'Some text',
'type' => 'text',
'slug' => 'some_text',
]),
When using the_papi_field
, line breaks should be converted to <br />
tags by default but are actually escaped: <br />
What I expected
Line breaks should be converted to <br />
tags but should not be escaped.
Problem
There's a contradiction with text property settings.
In order to allow nl2br
to work, allow_html
has to be set to false
: https://github.com/wp-papi/papi/blob/master/src/properties/class-papi-property-text.php#L19
But if allow_html
is set to false
, the value is escaped: https://github.com/wp-papi/papi/blob/master/src/properties/class-papi-property-text.php#L57
Thus escaping the <br />
tags produced by nl2br
.
What versions of softwares are you using?
- Papi: latest
- WordPress: latest
frozzare commented
Thanks, fixed and will be out shortly.