Code Review
Opened this issue · 1 comments
Hi Wenqiang,
Your project is perfect to me. you provide a gif demo example of how to analyze comments of a Weibo about Eddie Van Halen's death. It makes me clearer about the process. Second, in your google NLP project, you separated your function and testing into two files. It is easier for others to read. Moreover, in the testing google NLP, you tested with Chinese sentence. It is nice to test in different languages. You also mentioned 4 references. It is good to cite the API documents. But there is one thing was not perfect to me. I think your gif is moving a little bit fast. I have to look through a couple of times to know what commands you typed. So, in this case, I would prefer detailed images explanation. Overall, it is a perfect project.
Thank you for your review.
I will improve the demo example when I'm free/