Overlapping polygon analysis
k-kresek opened this issue · 10 comments
20211220164143991.mp4
Issue with selecting polygon from map. When you click a polygon, it redirects to the attribute tab even when you are selecting the polygon for use in overlapping analysis. Polygon selection is unable to be added to overlapping analysis.
@k-kresek We are trying to replicate the issue but are unable to view the layers coming from https://gis.forest-atlas.org/server/rest/services/. Do you know of any issues with the server that holds these layers? It looks like it is down at the moment. Here is the webmap link as well, https://blueraster.maps.arcgis.com/home/webmap/viewer.html?webmap=0c7952395699462cafe4427e0981cfe2, if needed.
@k-kresek It looks like when you select a polygon to analyze you need to select the 'Add to Analysis' button in the attribute tab. Please let me know if this addresses the issue. Thanks!
overlap_poly_analysis_issue.mov
Yes! This definitely addresses the issue - thanks for pointing that out! Do you think it's confusing that a user has to go back and click 'add to analysis' after they indicated they want to add a selected polygon to an overlapping analysis? Currently, upon entering the map, they would have to:
- Click on one shape
- Navigate to analysis tab
- Click analyze overlapping area
- Go back to previous tab to view attributes of original shape
- Click "add to analysis"
Is there a way to autopopulate the polygon that they originally selected into shape one?
Thank you!
Is it valuable for the user to see the attributes of the polygon before adding to the analysis?
20220107151518578.mp4
Interesting behavior with highlighting of polygons. Issue happens when user:
- Selects polygon
- Goes to analysis and selects multi polygon analysis
- Goes to analysis tab and selects add to analysis
- Selects shape two and clicks on polygon of choice
- Changes mind and selects a different polygon
Issue is that previously clicked polygons do not become unhighlighted. Correct highlighting would remove the highlight from the previously clicked polygon and highlight only the most recently clicked polygon.
@k-kresek I found a solution for the highlighting issue.
I did the following:
- Highlighted selected polygons for analysis with a red outline
- If two polygons are selected for the analysis, it turns off the 'Add to Analysis' button
- Corrected issue when selecting a shape and adding an additional polygon to Add to Analysis. It will now remove the old selection.
- Corrected when a user deletes a shape in the polygon analysis tool
When you get an opportunity could you please do some more testing to see if the issues you were seeing are now corrected?
Here is the testing link: https://alpha.blueraster.io/gfw-mapbuilder/pull-requests/multi-poly-work/
@davidlstarr Thank you! This looks good, I like the color distinction and after testing, this feature is working the way you described.
@davidlstarr - Just finished up with some additional testing. this feature looks good and I am ready to approve. Thank you for your work!
@k-kresek Perfect! I will proceed and let you know once it is deployed to production.