Attack animation

Question

Attack animation

Ryan-BLKST opened this issue 2 years ago · 10 comments

Hello,

It seems that localized 'global value' name is messing up the per item attack animation.
On the french version, the popup brings (valeur global) as default but it cannot be saved as such, the system displays 'Custom animation was removed'.
It 'works' when (global value) is placed instead but I cannot play custom sounds.

Tested on blank world, 1.80-alpha8 / FFG Star wars Enhancements 2.0.0

Thank you again for your work !

Answer 1 · 2023-02-02T19:54:00.000Z

I think you're misunderstanding how it works. You cannot set a custom value for one part; you must set a custom value for each of the three fields - animation file, sound file, and number of times to play. If you leave any of them as default, it will unset it instead.

Answer 2 · 2023-02-03T09:45:30.000Z

Isn't the (global value) supposed to get the value from the global FFG Enhancement setting ?

Also, when trying to set with default values (copy pasted from the settings), it does not work

Answer 3 · 2023-02-03T15:06:17.000Z

(global value) (or the localized version) is supposed to use the values set in the module settings. You can only set custom values in that window when none of them are set to (global value).

What happens when you try to save with your screenshot?

Answer 4 · 2023-02-03T15:56:28.000Z

You can only set custom values in that window when none of them are set to (global value).

I do not understand, do you mean the global settings (in Options => FFG Enhanced => Attack animations) must be blank for the custom values to work ?

What happens when you try to save with your screenshot?

It saves but no sounds or animation is played when attacking

Answer 5 · 2023-02-03T17:36:12.000Z

This will not work:

Neither will this:

All settings must be set to something other than the default value or it will "remove custom animation".

Can you try changing the skill the weapon is using and let me know if it works for any skill?

Answer 6 · 2023-02-03T18:04:13.000Z

The error may actually be somewhere else.
I was testing with 1 animation count, it does not work. But when testing with values of 2 or more, it works.

It seems sound and animation are played 1 time less than the value indicated in "Animation count".

Answer 7 · 2023-02-04T22:48:29.000Z

Thanks for offering to take this @bheiskell, looking forward to your fix

Answer 8 · 2023-02-04T23:27:19.000Z

Chatting with @wrycu, there may be an off by one bug, causing 1 to become 0 attacks.

Answer 9 · 2023-02-13T00:37:15.000Z

I confirmed it's an off by one in my local environment. Looking into how to fix it. As a work around, set animation count = 2.

Answer 10 · 2023-02-18T22:43:53.000Z

Will be released in 2.0.2.