wsp-sag/network_wrangler

[BUG] Nodes need to update their geometry if their XY changes.

Closed this issue · 1 comments

e-lo commented

Describe the bug

Geometry needs to update when XYs are added or changed.

Failing tests

  • No applicable test failed, need to create.

Thoughts on resolution

Initial implementation from "works with ranch" branch...

Notes:

  • this should actually be done for updating XYs as well, not just new ones

Within: def add_new_roadway_feature_change

node["new_node"] = 1
        
# add geometry for new nodes
self.nodes_df["geometry"] = self.nodes_df.apply(
lambda x: Point(x["X"], x["Y"])
                if x["new_node"] == 1
                else x["geometry"],
                axis=1,
            )

self.nodes_df.drop(["new_node"], axis=1, inplace=True)
e-lo commented

Complete with merging of #310