wtetzner/exploding-fish

Naming feedback

christianromney opened this issue · 4 comments

Great to see this library. Also love how closely the naming mirrors RFC 3986. I was curious about scheme-specific-part, though.

The closest thing to it in the RFC seems to be hier-part. I've often seen it referred to as the protocol-relative url although scheme-relative url would is probably nicer in terms of RFC idioms.

I won't presume to tell you how you ought to name your methods, I only wanted to offer some alternatives for you to consider. Again, thanks for creating this-I look forward to using it.

Which of those do you like best? I do kind of like 'scheme-relative'.

Me too. It's clear, short, and uses RFC terminology.

I renamed scheme-specific-part to scheme-relative.

Very cool. Thanks again for this library. :)