wtforms/wtforms-sqlalchemy

Automated tests not (100)

openbrian opened this issue · 2 comments

openbrian commented

2 issues here:

  • undefined variable "prop"
  • mysql YEAR converter is for wrong class
openbrian commented

I was running python setup.py test with these packages installed in a virtualenv.
SQLAlchemy 1.3.5
WTForms 2.2.1

python 3.6.3

I was getting this error.
wtforms_sqlalchemy.orm.ModelConversionError: Could not find field converter for column mysql_year (<class 'sqlalchemy.dialects.mysql.types.YEAR'>).

I resolved this by changing "base" to "types" in the converter. Evidently I broke every combination of test in Travis.

openbrian commented

So I realize now this issue is more about using modern version of python and library dependencies. I upgraded them as well.