Tapping on nodes that are part of a way does not present the Quest UI

[tordans]

Node: https://www.openstreetmap.org/node/433727998

This is about the bus shelter challenge.

• I have it active
• I tab the given node
• Nothing happens
• To double check, I tab a different challenge (handrail) - which works

(the one that is inactive here, but active for the test)

[wtimme]

Thanks for the report and the screenshots, @tordans! It was very helpful that you provided the link to the node. That way, I was able to take a look myself.

Indeed, at first it seems as if that particular bus stop was not selectable. However, if you long-tap, you'll see that there are quite some objects that can be selected:

I had a quick look at iD (to see if there was an issue with the data), but it looks fine to me. I think the culprit here is the way that the app figures out what it think you tapped. If you select the last option in the list that is presented upon long-tap, the quest dialog shows up as expected:

Maybe it makes sense to prioritize quest-enabled objects for the tap. What do you think?

[wtimme]

After a bit more digging, I realized that the issue is the lack of support for Quest-related nodes that are part of a way. I was not able to figure out a quick solution for this without introducing a lot of messy code.

[bryceco]

Yes, if you want to directly select a node that is part of a way without first selecting the way then it’s going to be messy. You can probably update the hit-testing code to do what you want, but you you’ll want to ensure you select the (correct) way it belongs to simultaneously. If you don’t then you could easily break assumptions made in other parts of the code.