wttech/gradle-environment-plugin

[NOT A BUG] Pending reloading should be canceled if new change is detected

pun-ky opened this issue · 2 comments

pun-ky commented

to avoid reloading twice unnecessarily when using environmentDev task

mierzwid commented

I thought to rewrite this code to use Flow - it would be possible, but will take lots of time and require reworking the entire solution. It would require changes in the common plugin alongside the environment plugin.

I don't see a problem here. After a process is reloaded and there are pending file changes, then it is reloaded once for the entire set of changes. Additionally, after health checks are done, and in the meantime any reload happened we check once again to make sure the last reload hasn't damaged anything.

pun-ky commented

the last reload hasn't damaged anything.
 

but I think that reload should be idempotent so it could be canceled at any time. 

and that's the case