wuba/metro-code-split

Ability to name chunks

hamdiwanis opened this issue · 2 comments

hamdiwanis commented

First of all thanks for the great lib.

I was wondering if there is a way to name chunks the same way webpack do?

zq0904 commented

First of all, thank you for asking

At present, there is no configuration or support for this function, and it will not be supported in the short term (sorry to be a little busy), but the implementation is not very complicated, welcome PR.

Some feasible technical implementation schemes:

  1. Obtain the name of the annotation or directly use the name of the loading chunk
    1.1 get the comment name: metor customSerializer graph reference：graph.dependencies.get('xxx').getSource()
    1.2 or directly use the name of the chunk to load: Reference val.modules

    metro-code-split/src/config/dynamicImports.js

    Line 117 in f5ac458

    const { code } = mcs.bundleToString({ pre: '', post: '', modules: val.modules })

  2. Export chunk: reference

    metro-code-split/src/config/dynamicImports.js

    Line 127 in f5ac458

    const dir = path.resolve(mcs.outputChunkDir, `${hash}${output.fileSuffix}`)

  3. Make sure chunk loads as scheduled:
    3.1 the reference

    metro-code-split/src/tpl/wrapAsyncRequire.ejs

    Line 32 in f5ac458

    chunkModuleIdToHashMap[chunkId]['hash'] + '<%= options.fileSuffix %>'

    3.2 or use asyncRequireTpl for customization

    metro-code-split/src/index.js

    Line 35 in f5ac458

    asyncRequireTpl: require.resolve('./tpl/wrapAsyncRequire.ejs'),

krmao commented

hi , thanks for the greate lib,
please how to rename/special output dll/buz bundle name?, such as common.android.bundle, business-a.android.bundle @zq0904