wunderio/code-quality

Ignoring subfolders doesn't seem to work on locations defined in run_on

tormi opened this issue · 1 comments

tormi commented

Ref: https://wunder.slack.com/archives/C5B9YGQSE/p1597407241011400

How can I define working ignore_patterns for folders which are subfolders of ones which are defined in run_on? This doesn’t seem to work:

    ecs:
      run_on: ['web/modules/custom', 'web/themes/custom', 'web/sites']
      ignore_patterns:
        - '/web/sites/default/files/'

Screenshot 2020-08-14 at 15 41 58 (1)

cc: @guncha25

tormi commented

Still relevant:

    php_stan:
      run_on: ['web/modules/custom', 'web/themes/custom']

gave me

php_stan
========

PHP Warning:  file_get_contents(): Filename cannot be empty in /app/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php on line 43
Warning: file_get_contents(): Filename cannot be empty in /app/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php on line 43
Error thrown in /app/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/RunnerVersion.php on line 27 while loading bootstrap file /app/vendor/mglaman/phpstan-drupal/drupal-autoloader.php: Class 'PHPUnit\Runner\Version' not found