Commit when CG closed
baconalot opened this issue · 2 comments
baconalot commented
It would be nice if zookeeperOffsetManager.commitOffsets() got called from ConsumerGroup.Close().
Right now stuff that is 'markedForCommit' after the last commit and before CG close is dropped.
Maybe also provide a Commit() method in the OffsetManager interface to be able to force commits from CG/clients.
wvanbergen commented
During a normal shutdown, there should be no difference between marked for commit, and committed, because the offsets are committed for every partition consumer as they wind down.
wvanbergen commented
Closing this - as this should already work. Also #72 improves how we keep track of offsets.