wwivbbs/wwiv

Optional lines in Full-Screen Message Reader displays line numbers above 2

Closed this issue · 7 comments

In the Full-Screen Message Reader, the optional lines gets displayed differently from the Traditional Message Reader.

Example:

Using the Full-Screen Message Reader:
Screenshot from 2023-01-03 19-45-31

Using the Traditional Message Reader:
Screenshot from 2023-01-03 19-45-07

wwiv commented

trying to step through this under a debugger, it seems that for some reason in the FrameBuffer class it's thinking it's in a pipe code on here and that's causing issues.

it's odd that the Traditional Message Reader parses it properly, while the Full Screen Reader doesn't.

it's a difference between display_message_text() and split_wwiv_message() in the loop that handles optional lines.
just for completeness, here's the .tag file used for that message.
WWIVDEV.txt

The lines use WWIV heart codes (?) Ctrl-C for colors.

wwiv commented

The full screen reader has to write out the ANSI to a frame that can be scrolled, since absolute positions, etc don't work for a scrollable view.

OK. I tried making the same .tag file with Pipe codes in place of Heart codes and the Full Screen Reader rendered it more or less correctly (but the word-wrap messed up the formatting). Does the FS Reader count pipe codes or heart codes as multiple chars, or zero chars to add to the line length? I'm getting sleepy now, so I can't pursue this now.

wwiv commented

Will you attach your old .tag file here so I can try it out more easily?

wwiv commented

This seems to fix it, I still need to clean up it up a bit before i merge it in.

wwiv@9c12d76

wwiv commented

Fixed and merged in 94b38a0