Update to eslint-config-norton v4
sh0ji opened this issue · 2 comments
sh0ji commented
The latest 4.0 beta of eslint-config-norton has some breaking changes in it that will require some effort to update in the design system, which is why I opted not to update it for the first release candidate. Let's start that work. Some notes:
- We're currently using nested
.eslintrc
files to apply different rules to different packages via the eslint configuration cascade. These should probably be removed since the new config targets file globs to determine which rules to apply (it uses overrides), allowing us to use one root config. We'll want to enforce no default exports, which is in.eslint-config-norton@4.0.0-beta.0
but not in subsequent versions. I opened an issue about this in the style repo- There will be new type errors since we're not currently using the recommended-requiring-type-checking. Some of these type errors might require real refactoring or point to actual issues. We'll tackle those on a case-by-case basis.
ParmeJon commented
I have the norton config set up locally. I kept some of the individual rules for docs
and packages/react
. Currently, looking at 336 errors and 77 warnings after an initial npm run lint:es-fix
. Will be working on the eslint-config-norton-v4-upgrade branch.