GraphConstructor prep_mtrx order of checks matters?

[jernsting]

Lines 83 and following of GraphConstructor are:

    def prep_mtrx(self, adjacency):
        """transforms the matrix according to selected criteria"""
        if self.fisher_transform:
            adjacency = individual_fishertransform(adjacency)
        if self.use_abs:
            adjacency = np.abs(adjacency)
        if self.zscore:
            adjacency = individual_ztransform(adjacency)
        if self.use_abs_zscore:
            adjacency = np.abs(adjacency)

        return adjacency

• Does the order of this checks matter?
• Why is the fisher_transform not calculated on the absolute values of the adjacency if np.abs is passed
• Should there be a use_abs_fisher_transform paramter?
• Write Tests for all possible combinations of parameters

[VHolstein]

The order of checks matters, but even in CONN there is no good explanation for why they would choose this order.

[VHolstein]

• Indent fisher_abs & zscore_abs
• Add tests for combinations of tests: abs + fisher + zscore; fisher + abs + zscore, fisher + abs + zscore + abs