wyskoj/midis2jam2

Half the supposed instruments dont show up

Closed this issue · 1 comments

Describe the bug
A clear and concise description of what the bug is.
The instruments would show up.

Offending MIDI file
Upload the MIDI file that causes the bug here.
https://www.mediafire.com/file/x880595mrrc6ho1/Animusic_1.4_-_Drum_Machine.mid/file

Expected behavior
A clear and concise description of what you expected to happen.
The instruments would pop up (the instruments ARE supported in this midi)

That MIDI file sets the program of the rhythm channel to 14 (0xE), which is not recognized by any major MIDI specification (GM, GS, and XG). midis2jam2 falls back to a standard drum set if an unexpected value is seen, but doesn't go out of its way to catch this for auxiliary percussion. The fix is to rectify the value of the program change event in the MIDI file.