Pagination fails with no results

Question

Pagination fails with no results

jbraithwaite opened this issue 12 years ago · 16 comments

I'm using pagination with a filter which means my API needs to return zero results sometimes. This causes the following Range Error to be thrown:

Uncaught RangeError: `currentPage` must be firstPage <= currentPage <= totalPages if 1-based. Got 1.

Where:

> firstPage
1

> currentPage
1

> totalPages
0

Even if I set totalPages to 1 in my API it gets set to zero which is causing the error to be thrown.

Answer 1 · 2013-02-09T06:50:14.000Z

Can you paste a log of the state metadata in your response body here?

Answer 2 · 2013-02-09T08:28:43.000Z

This is on the last time _checkState() is fired

{
  currentPage: 1
  filterStatus: undefined
  filterText: undefined
  firstPage: 1
  lastPage: 0
  order: null
  pageSize: 15
  sortKey: null
  totalPages: 0
  totalRecords: 0
}

It fires three times when I do a get*Page.

Answer 3 · 2013-02-11T04:56:55.000Z

You don't have to return so many states in your response body, you just have to return totalRecords, and everything else will be recalculated when necessary. Alternatively, you can set totalRecords to null instead of 0 to skip _checkState.

Answer 4 · 2013-02-14T23:43:39.000Z

Returning null worked like a charm!

Answer 5 · 2013-04-18T12:11:34.000Z

It seems that issue with processing 0 in totalRecords is about totalPages calculation:
totalPages = state.totalPages = ceil(totalRecords / pageSize)

Assuming that firstPage === 1 for empty response, should the totalPages become 1 also?

Answer 6 · 2013-04-18T12:44:10.000Z

Why would an empty response indicate having > 0 number of pages?

Answer 7 · 2013-04-18T12:56:59.000Z

Considering the following condition:
firstPage === 1 && (currentPage < firstPage || currentPage > totalPages)

The state has firstPage === 1, currentPage === 1 and firstPage === 1. Passing condition leads to RangeError throwing. So there are two approaches: keep all related state properties actual (being 0) in case of totalRecords === 0 or force totalPages = 1 in this case.

As for me, server API should response only with total_entries === 0 in case of empty collection (e.g. after filtration). So the question is: should it be treated as first and single page (totalPages === 1)? If not, then the only way is to respond with total_entries === null (which makes server API less consistent).

Answer 8 · 2013-04-18T13:30:54.000Z

The better question is, under what circumstances would you ever reach that state by using the paginator's methods? Are you manually fiddling the state yourself?

Answer 9 · 2013-04-18T13:39:45.000Z

Yes, I'm setting state.currentPage = 1. But before fetching the filtered results.

Answer 10 · 2013-04-18T13:47:18.000Z

Would this work for you?

else if (firstPage === 1 && (currentPage < firstPage || currentPage > totalPages && totalPages > 0)) {

Answer 11 · 2013-04-18T13:50:08.000Z

Also, which mode are you using?

Answer 12 · 2013-04-18T13:58:00.000Z

I'm using the "server" mode and yes - this condition works. So the question is about which workaround to use - && totalPages > 0 or ceil(totalRecords / pageSize) || 1. Your one assumes that state.totalPages really should stay 0. It seems that we are about some "domain" choice - is it correct to say that we have a page for empty collection or not?

Answer 13 · 2013-04-18T14:00:42.000Z

Can you obtain a grain of salt from an empty jar? That's a contradiction. I'll commit a fix for this. Thanks for letting me know.

Answer 14 · 2013-04-18T14:12:55.000Z

But a jar is not supposed to disappear due to lack of salt :) Anyway, thanks a lot.

Answer 15 · 2013-11-13T12:18:09.000Z

What if ?
currentPage: 4
firstPage: 1
pageSize: 10
totalPages: 1
totalRecords: 5

I am getting same issue! Plz help!

Answer 16 · 2013-11-13T13:24:54.000Z

How can you have a totalRecords of 5, a pageSize of 10 and be on page 4? Of course you get an error.