backbone-paginator/backbone-pageable

Potential bug in _makeFullCollection

ileto opened this issue · 3 comments

var fullCollection = new (Backbone.Collection.extend(proto))(models, options);

  for (i = 0, length = properties.length; i < length; i++) {
    prop = properties[i];
    if (this[prop] !== thisProto[prop]) {
      fullCollection[prop] = prop; // WHY set the literal prop ?
    }
  }

Haha good catch. It should be this[prop]. Care to make a PR and a test case?

Hmm, don't know how to do the PR or test case. You do the "hard" work... 👍

Fixed in 91869a1