Potential bug in _makeFullCollection
ileto opened this issue · 3 comments
ileto commented
var fullCollection = new (Backbone.Collection.extend(proto))(models, options);
for (i = 0, length = properties.length; i < length; i++) {
prop = properties[i];
if (this[prop] !== thisProto[prop]) {
fullCollection[prop] = prop; // WHY set the literal prop ?
}
}
wyuenho commented
Haha good catch. It should be this[prop]
. Care to make a PR and a test case?
ileto commented
Hmm, don't know how to do the PR or test case. You do the "hard" work... 👍