Format with google-java-format
t0t07 opened this issue · 2 comments
t0t07 commented
The code format is a little bit off. Will you consider formatting the code base with https://github.com/google/google-java-format, and furthermore make it part of the build process? This way no code without being properly formatted can be checked in.
wzhe06 commented
This is a good point for sure. While SparrowRecSys in this stage is mainly for beginners' practicing and more modules and languages may be added to this project meanwhile. Let's do stricter format check after all main modules has been added. And I will transfer the project to a formal open source project by then. Thx.
YikSanChan commented
Sounds good
Wang Zhe <notifications@github.com>于2020年10月5日 周一上午12:12写道:
… This is a good point for sure. While SparrowRecSys in this stage is mainly
for beginners' practicing and more modules and languages may be added to
this project meanwhile. Let's do stricter format check after all main
modules has been added. And I will transfer the project to a formal open
source project by then. Thx.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDOKNIY3MCULZKP2NOPVS3SJFWW5ANCNFSM4SEIBCKQ>
.