x-team/unleash-styles

Header components - mobile

Closed this issue · 5 comments

jacekelgda commented

We need to figure out what will be the best way to implement mobile css.
In styleguides provided by @agiannastasio mobile styles are in separate files. I am not sure if we can keep that approach using css modules.

Please discuss first.

agiannastasio commented

We could merge the menu styles in one single file, no prob with that. The issue I think is the actual mobile menu, which I implemented in JS:
https://github.com/x-team/unleash/blob/styleguide-dev/styleguide/src/js/mobile-menu.js

jacekelgda commented

Thanks for info @agiannastasio , I don't think it will be a problem to implement js logic in component.

  • 👍1