xwp/stream

Database Update may cause error when invoked from Updates screen

fjarrett opened this issue · 4 comments

In some cases, when clicking the Update Database button while on the Dashboard > Updates screen, a wp_die error occurs.

When you click update database, the form redirects you to the calling page which might be wrong in some cases. I experienced an issue where I would click update on the plugin page and it would redirect me on a completely different page after.

The problem might be coming from the use of wp_get_referer() here: https://github.com/x-team/wp-stream/blob/b3f0a76edf45fab842ec8f1c8e80266a692397ba/includes/install.php#L168

See this ticket in Trac: https://core.trac.wordpress.org/ticket/2858

Even though this bug was fixed years ago, it seems to be exactly what we are experiencing.

Fixed as part of #449 in L199. Will be fully resolved when that PR is merged.

Props @c3mdigital

Actually, this was fixed in dbe4465. Props @westonruter.