reserved identifier violation

Question

reserved identifier violation

Closed this issue 9 years ago · 8 comments

I would like to point out that identifiers like "__tagged_value" and "_HL_HASHTABLE_H_" do eventually not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

xant commented 9 years ago

19c7df2

Answer 1 · 2015-08-27T18:47:27.000Z

will fix by removing the underscores from all headers

Answer 2 · 2015-08-27T19:00:21.000Z

@elfring are you actually using this package or just making sure it fits a set of style guidelines?

Answer 3 · 2015-08-27T19:02:24.000Z

Some uses of double underscores should also be reconsidered, shouldn't it?

Can C standard-compliance help you to reduce the error probability around specific implementation details?

Answer 4 · 2015-08-27T19:32:19.000Z

isn't that c++ ?

Answer 5 · 2015-08-27T20:20:34.000Z

Thanks for your improvement of affected include guards.

There are a few update candidates left over.

Answer 6 · 2015-08-27T20:59:29.000Z

but those are macro arguments ... I think there is no point in changing those since their scope is limited to the actual macro implementation. Is this being reported by some analyzer?

Answer 7 · 2015-08-27T21:18:27.000Z

Macro arguments are also identifiers. Would you like to clean-up the remaining source code places which tamper still with the reserved name space?