missing binder links
dcherian opened this issue · 3 comments
dcherian commented
scottyhq commented
Strange. Took me a while to figure this out, but it is a side effect of #83
Adding kernelspec
back into the notebooks brings back the rocket ship, it's possible it can just be empty, would have to test...
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
scottyhq commented
"metadata": {
"kernelspec": {
},
An empty dictionary doesn't work b/c jb build
runs nbformat
to check metadata tags:
ERROR: Notebook is invalid after preprocessor <nbconvert.preprocessors.tagremove.TagRemovePreprocessor object at 0x112c54a30>
Exception occurred:
File "/Users/scott/miniconda3/envs/xarray-tutorial/lib/python3.10/site-packages/nbformat/validator.py", line 302, in validate
raise error
nbformat.validator.NotebookValidationError: data.metadata.kernelspec must contain ['name', 'display_name'] properties
Failed validating <unset> in notebook['data']['metadata']:
scottyhq commented
Seems that simply waiting has fixed this one :) Maybe bumping jupyterbook versions, but the rocket ship binder launch buttons are back!