xarray-contrib/xwrf

[Bug]: Github logo only visible with dark mode

Closed this issue · 5 comments

lpilz commented

Unfortunately the logo in Github is completely invisible in light mode - we should consider maybe choosing grey or something. Or we could have a non-transparent background

jthielen commented

What browser and OS are you using? When I checked in both both Firefox and Chrome, the light and dark background toggling of the logo is working properly:

image

image

lpilz commented

Sorry, I should have clarified I mean the logo in Github. I'm using Firefox 98.0.1 on Arch Linux and for me it looks like this:
grafik

  • 👍1
andersy005 commented

Unfortunately the logo is completely invisible in light mode - we should consider maybe choosing grey or something

Yeah the README.md is tricky. It's worth looking into having a third/neutral version for environments in which we can't easily toggle between dark and light mode

  • 👍1
lpilz commented

I found this in the Github docs. Would this work for us?

![GitHub-Mark-Light](https://user-images.githubusercontent.com/3369400/139447912-e0f43f33-6d9f-45f8-be46-2df5bbc91289.png#gh-dark-mode-only)![GitHub-Mark-Dark](https://user-images.githubusercontent.com/3369400/139448065-39a229ba-4b06-434b-bc67-616e2ed80c8f.png#gh-light-mode-only)
  • 👍1
kmpaul commented

It seems to work for me. Here is the markdown rendering of what just pasted above. Try switching it back and forth from light to dark modes to see if it renders appropriately.

GitHub-Mark-Light
GitHub-Mark-Dark