xaviersolau/BlazorJsonLocalization

Feature requests

Closed this issue · 3 comments

m4ss1m0g commented

First of all, thanks for a great job, I looked at the source code, and is very well written (with comments!).

I would suggest you some improvements:

  1. Change the name resources separator from - (dash) to . (point) : now is -fr-FR.json by I think is better to adhere to the resx standard dot-like .fr-FR.json or at least provide a parameter to specify the separator.
  2. Update the Doc to specify wildcards to include ALL Resources see the Microsoft Docs or update the code to embed resources by defaults.
  <ItemGroup>
    <EmbeddedResource Include="Resources\**\*.json" />
  </ItemGroup>
  1. The JSON format: I think it's will very interesting if the libs adhere to Javascript i18n structure with nested/complex objects, but I think is not quite simple to implement.

Thanks.

xaviersolau commented

Thanks for your feedback!

I will update the doc with the wildcards version of the ItemGroup declaration!

Point 1:
I may be considering to add an option in the hosted resources. Unfortunately it won't be possible for EmbeddedResources since there is some constraints with dots in the resource file name (see this for more information).

Basically, I can load the embedded files as soon as there are more than one dots in the file name. Even playing with
LogicalName option.

Point 3:
I will investigate this.

  • 👍1
xaviersolau commented

working on #42

xaviersolau commented

Structured Json can be used in version 2.0.0-alpha.1

  • 🎉1