No textures for Confluence with Nexus

Question

No textures for Confluence with Nexus

Closed this issue 2 years ago · 16 comments

not sure if somebody is already aware of this. installing confluence under current master looks like this

all good when installing under Matrix

Answer 1 · 2021-10-05T09:04:39.000Z

@howie-f I can confirm this.
It seems confluence is submitted to the Nexus repo. But the Textures.xbt file is only 9 byte.

EDIT: Weird, because it's not here: https://github.com/xbmc/repo-skins/tree/nexus
But it's uploaded to the mirrors: https://mirrors.kodi.tv/addons/nexus/skin.confluence/

Answer 2 · 2021-10-05T09:08:49.000Z

Last PR's are by me, but only for Leia and Matrix repos.
@ronie Any idea what hapened?

Answer 3 · 2021-10-05T09:32:55.000Z

i was a bit surprised that confluence is available in the nexus repo. is that intended?

Answer 4 · 2021-10-05T09:34:26.000Z

I don't think so.
No big changes are added between the two branches.
I submitted Confluence for Leia and Matrix, but not for Nexus.

Answer 5 · 2021-10-05T09:44:32.000Z

matrix skins are indeed available to kodi matrix, which is intentional.
else there wouldn't be any skins (or any addons at all) available to kodi matrix,
since no skins (or other addons) have been submitted to the nexus repo yet.

the repo logic is defined by this file:
https://github.com/xbmc/repo-scripts/blob/97b2f3e83a6a09b58ff19d562c66e9d8a2a72f9d/targets.cfg#L88-L95
to matrix users, we serve all addons from the gotham to nexus branches, if the addons meets the defined minversions.

Answer 6 · 2021-10-06T10:37:03.000Z

@gade01 i had a bit of time to look into it but i have no idea what caused the corrupt Textures.xbt.
if i compile the Textures file locally, using Texturepacker from master, it succeeds without any issues.

perhaps you can do another PR for Confluence?

Answer 7 · 2021-10-06T10:40:13.000Z

@ronie Ah, so all matrix skins were added to nexus repo when it was created?

Would you like me to submit Confluence to Matrix repo again?

Thanks a lot for looking into this.

Answer 8 · 2021-10-08T14:06:25.000Z

…if i get it right the targets.cfg just says: take all add-ons from gotham..to..nexus branches, check xbmc.gui=5.15, xbmc.python=…., and if all matches shove the zip to the nexus repository.
this would explain there are 15 skins available in matrix and in nexus atm. (including confluence in both)

statement from a guy who has no idea how the repos are set up 😌
but still doesnt explain why textures.xbt got shot

Answer 9 · 2021-10-08T16:38:11.000Z

@ronie Should I submit again to Matrix or Nexus repo?

Answer 10 · 2021-10-08T18:50:02.000Z

@howie-f that is fully correct. why the textures file corrupt, i don't know either.

@gade01 please submit to the matrix repo only, that'll make the skin available to nexus as well.
(hopefully with a functional textures file this time)

Answer 11 · 2021-10-09T09:27:25.000Z

@ronie Great thanks.
I'll do that later today :)

Answer 12 · 2021-10-09T11:08:34.000Z

@ronie @howie-f
Confluence has no media files in the repo, only an already compressed Textures file. That's probably the reason.
https://github.com/xbmc/repo-skins/tree/matrix/skin.confluence/media

New PR created: xbmc/repo-skins#349

Answer 13 · 2021-10-09T19:52:44.000Z

Confluence has no media files in the repo, only an already compressed Textures file.

damn, yeah, that must be it. obviously something i messed up after the last PR was merged into Matrix.
i'll merge the new PR right away and keep an eye on things, though i'm sure all should be ok now.

Answer 14 · 2021-10-09T22:33:51.000Z

Thanks a lot :)

Answer 15 · 2022-04-19T09:25:55.000Z

@howie-f The issue should be solved now?

Answer 16 · 2022-04-19T10:45:28.000Z

hi @gade01 and @ronie
yup, looks pretty good now. like we‘re used to. thanks