Mark PM read when viewing
rwestergren opened this issue · 9 comments
This is already done AFAIK.
Have another report of this: http://forum.xda-developers.com/showpost.php?p=55909548&postcount=24
https://github.com/xda/XDA-One/blob/master/android/src/main/java/com/xda/one/ui/ViewMessageFragment.java#L133 - you can see that if I'm viewing the PM and the model says that it is unread, then I tell the server to mark it as read.
Yeah, I just confirmed this working correctly on my device.
After further clarification from the reporting user, this is actually an issue with the "notifications" count not being updated. This makes sense since after reading a PM, the app should request the notification counts again and fill them in.
This would also be true for mentions/quotes, but I still need to create a method to mark these are read.
Those methods are now available: https://api.xda-developers.com/explorer/#!/user/mentionNotifications_delete
Can this be changed slightly so that when someone retrieves the mention/quote feed, the notifications for that feed is cleared rather than me calling it?
It could, but we were trying to make it consistent with the site, i.e. just because you see the notification counts "fetched" doesn't mean you've reviewed them.
Right I see. OK will do it that way then.