xiaoxiaoflood/firefox-scripts

Nightly (2023-02-22) breaks DownThemAll interaface

jiangzhenjerry opened this issue ยท 15 comments

Today (2/22/2023) Firefox Nightly breaks the interface of DownThemAll again. It looks funny (but still functional!)

sshot-1

OK things are getting worse today... I cannot see the window control (min/max/close) anymore...

2023-02-23_160531

They also broke the Password Manager interface again, it's like the fourth time in the last six months.

Same issues with DTA with FF update 112.

moz-image-region removed in bug from ff code, but not removed from HTML5
DownThemAll-3.1.2.112.2023.04.22-xiao.xpi.zip

@dimdamin Thanks for the fix! Appreciated.

jathek commented

moz-image-region removed in bug from ff code, but not removed from HTML5 DownThemAll-3.1.2.112.2023.04.22-xiao.xpi.zip

Anyone else having issues resizing columns in the download manager? Some of the columns refuse to shrink and it's pushing the scrollbar out of the window.

Small missed icon, I think:
image

Overall great fix, thanks.

Anyone else having issues resizing columns in the download manager? Some of the columns refuse to shrink and it's pushing the scrollbar out of the window.

Yeah... I'm also observing squeezed columns that cannot be expanded.

sshot-1

Not only moz-image-region got removed, also multiple other moz-box-* CSS properties will be removed in v113 which will break the preferences panel completly.
My try on fixing it takes a different route with handling the moz-image-region by splitting the PNG images in multiple files, but the result is the same working extension.
Also the mentioned moz-box properties are handled (but only on win, mac und unix are not fixed and not tested).
dta.xpi.zip

TFWol commented

@xelsios Good change, thank you. Looks like it was annoying to do.

-- Edit --
It looks like something is glitched out. At some point the Make Your Selection window ends up being truncated like the folks above.

image

I updated the interface in DownThemAll and S3Download, works for me... Maybe it will be works for you to, tested at 102 and 113
DownThemAll-3.1.2.112.2023.05.10-xiao.xpi.zip
s3download-4.14.109.2023.05.10-xiao.xpi.zip

Thanks all for the DTA interface fix, that was nasty. I also saw where the columns in the DownThemAll interface were fixed in select.xhtml with flex-grow:. I was able to apply that to password manager with success.

Thanks @xelsios and @dimdamin for the fixes. Wanted to give all the DTA fans an update that DTA is completely dead under 115a1 starting 2023/05/13. I initiated a new bug report #259 to track. Hope there will be a fix eventually.

TFWol commented

I'm worried about @xiaoxiaoflood ; no activity on github for a couple of months.

I'm worried about @xiaoxiaoflood ; no activity on github for a couple of months.

He's around, I think he posts at Reddit as tustamido and there's new ones today.

https://old.reddit.com/r/XUL_for_Quantum_Dev/comments/fs76ff/little_update_current_fx_version_75/

TFWol commented

I'm worried about @xiaoxiaoflood ; no activity on github for a couple of months.

He's around, I think he posts at Reddit as tustamido and there's new ones today.

https://old.reddit.com/r/XUL_for_Quantum_Dev/comments/fs76ff/little_update_current_fx_version_75/

Ah good, thanks for the info; I've had a lot of developers I liked disappear lately