xing/paperclip-storage-ftp

Leaking ftp connections?

Closed this issue · 3 comments

So far, there is no explicit closing of the ftp connections. This may hit the limit of open files/sockets.

This JRuby exception might be related:

Exception: java.lang.ThreadDeath thrown from the UncaughtExceptionHandler in thread "Thread-2"
...

https://travis-ci.org/#!/xing/paperclip-storage-ftp/jobs/2900468

Yes, the code was potentially opening a new ftp connection per model object.

Fixed: 8250a67

The java.lang.ThreadDeath error on travis was not fixed by this. I could not reproduce it locally yet, though.