Some wrong keys get into cache
Closed this issue · 2 comments
In some special cases an invalid record get into the cache with the wrong key... investigating!
It seems solved!
But needs further investigation... because 'the solution' was to delete a call Cache() that should have raised an exception and under a condition that never happened (cache option equal to 'default')... why this 'side effect'?
[This was supposed to have been deleted some versions ago when cache was an experimental thing]
Fortunately, isbnlib doesn't used this.
Keep investigating...
The problem only happens when Google Books is involved ('default' is 'merge' and 'merge' uses Google Books)!
Google returns garbage when the isbn is not valid, and today even for some valid isbns! The end user script isbn_meta verifies the isbn and is not affected, but isbntools.meta doesn't (because the services usually respect the identifier ISBN).
So use EAN13 inside isbntools.meta, if isbn not a valid EAN13 just return None.