[Feature]: Create a reusable gh workflow for build xline image
Closed this issue · 5 comments
Description about the feature
Currently, there are multiple workflows that require building xline container images. It is worth creating a reusable workflow for building container images.
Xline/.github/workflows/benchmark.yml
Line 39 in 75e51f4
Xline/.github/workflows/validation.yml
Line 42 in 75e51f4
- #696 (comment)
Ideally, this reusable workflow will build the xline container image and upload the created image artifact through actions/upload-artifact.
Another option is to put the logic into a script and the user just needs to run a command like make build-container
to build the container image.
The other things is the xline container image tag created in the current workflow is latest
. I don't think this is a good idea. This is a real tag and in some scenarios it may be possible to pull the image from the repository instead of using the local.
Code of Conduct
- I agree to follow this project's Code of Conduct
Hi @liangyuanpeng @Phoenix500526 Please assign it to me. I would like to work on workflows. Thank You.
Thanks for your contribution. @ChaudharyRaman
@ChaudharyRaman Free feel to ask if you have any question here.
@liangyuanpeng sorry I was occupied with the college exam and writing a proposal for gsoc, will be raising a PR today for the issue.
No worries, just according to your time to choice it.