Linter Fix & Refactor Functions to Improve Readability
denopink opened this issue · 0 comments
denopink commented
copy & paste from xmidt-org/go-parodus#25
Refactor long functions
There are a few long functions that should be refactored and broken up into more readable sections.
By default, the funlen
linter has a limit of 60 lines or 40 statements per function. It is the goal to adhere to these standards.
Currently, the funlen
linter in this repo is disabled, this should be enabled as part of this issue. It can be enabled by adding it to the enable
section of the .golanci.yaml
config file.
To Do
- Enable
funlen
linter in the.golanci.yaml
config file - Run the linter
golangci-lint run
- Refactor and break up the functions the linter complains about
Update deprecated libraries
The staticcheck
linter checks for deprecated imports. This has been disabled for imports of webpa-common/v2/logging
, but should be enabled as part of this ticket. A new logger will need to be added.
To Do
- Search for
nolint:staticcheck
in the repo and remove the comments - Run the linter
golangci-lint run
- Reconfigure logging in those files, most likely using uber/zap