xmidt-org/tr1d1um

webhook integration tests fail with auto bump of zipkin and candlelight

piccione99 opened this issue · 1 comments

Below error happens starting at commit 1bcc2b9 during local integration tests. If that commit is reverted, the issue does not happen, even on the latest version.

It might still be worth testing in CD to verify the error occurs there, too.

The error happens for all the webhook tests in talaria/Connect_event_msgtype.robot (see image below)
body={"message":"failed to JSON unmarshal webhook: unexpected end of JSON input"}

image

I'm pretty sure I know what's happening. The changes I made in Candlelight v0.0.16 decodes the message in the middleware and stores the result in the context.
By the time Tr1d1um tries to decode the payload, it's already been read, thus the end of JSON input error.

When updating to this version of candlelight in Scytale, I had to include a check before trying to decode the payload again to avoid this error.

Tr1d1um's unit tests don't seem cover this, so Dependabot updated Candlelight and merged to main.