xmlsec/python-xmlsec

Release the new version

mxamin opened this issue · 30 comments

mxamin commented

Now that we have the fix for compliance with XMLsec v1.3.3, I guess we need to release a new version so we can close the related issue, trying to install with pip.
@jimjag @bgaifullin What do you think? Do you think of any preparation/changes before the release.
I can create the tag and the release note but since I don't have access to pypi, I need your help with that.

ayakael commented

I think y'all are still missing: #280 which makes the code changes for xmlsec 1.3.3.

ayakael commented

#253 will also be necessary for python 3.11 support, I believe. The code won't work as-is as it still references xmlSecCryptoAppKeyLoad rather than xmlSecCryptoAppKeyLoadEx. It can be merged, and adjusted after by replacing line 209 with key->handle = xmlSecCryptoAppKeyLoad(engine_and_key_id, xmlSecKeyDataTypePrivate, xmlSecKeyDataFormatEngine, NULL, xmlSecCryptoAppGetDefaultPwdCallback(),

jimjag commented

Both have been merged into HEAD

  • 🎉2
  • ❤️2
ayakael commented

Awesome! I made a mistake in the above comment. This final PR will fix things #285

mxamin commented

@ayakael #285 merged.

ayakael commented

Wicked! Build works on Alpine Linux using py3-lxml 4.94, py3-xmlsec 1.3.3 and python 3.11.

mxamin commented

With the new changes, you can't install the library using the old version of xmlsec1. I made a few changes to make it backward compatible: #286

mxamin commented

I also noticed that building the library would fail with the latest version of xmlsec1 (1.3.3) because of a typo: lsh123/xmlsec#755

pitbulk commented

Thanks to everyone involved in this hard work, keeping the project alive.

python3-saml depends on this great library and we are so happy that you are fixing the installation and other conflicts reported.

The release of a new version is so close, thanks again!

  • 👍5
nosnilmot commented

I strongly suggest you merge #246 (at least until #283 is resolved)

ryanhiebert commented

@nosnilmot afaict, that PR doesn’t block binary lxml for library users, it’s just for the library tests or something. I don’t see that it is referenced from setup.py.

  • 👍1
nosnilmot commented

that PR doesn’t block binary lxml for library users, it’s just for the library tests or something. I don’t see that it is referenced from setup.py.

oh boo, and from what I can tell there is no trivial way to specify 'no-binary' for dependencies installed by setup.py 😞

jdoklovic commented

is this going to be merged?

  • 👀1
jimjag commented

We are at the point where, we think, all required and available PRs have been merged.

  • 🎉4
  • 👀2
mxamin commented

We are at the point where, we think, all required and available PRs have been merged.

Perfect, @jimjag I can prepare the release (tag, change log, etc) but I don't have access to update the PyPI.

  • 👍2
jonathangreen commented

You might want to consider merging #299 before the new release goes out, since it makes it much clearer when the libxml2 version is out of sync between xmlsec and lxml. I've personally found this fairly difficult to get right, and I think this is evidenced by most of the CI builds failing because of this issue.

jimjag commented

#299 has been merged... I'll start looking into PyPI access

  • 👍4
  • 🎉3
mxamin commented

I also noticed that building the library would fail with the latest version of xmlsec1 (1.3.3) because of a typo: lsh123/xmlsec#755

I created an issue (lsh123/xmlsec#770) for this in xmlsec repo, they're planning to do the RC release today and release the new version in ~2 weeks. I guess that would be great if we finalise the changes by the end of this week, test it with xmlsec RC release and finally release a new version in the up coming week. What do you think?

  • ❤️1
jimjag commented

I have PyPI access... well, at least an account. So let's start with the release process. Coordinating w/ xmlsec makes sense.

  • 🎉2
mxamin commented

I created a pre-release https://github.com/xmlsec/python-xmlsec/releases/tag/1.3.14-rc1
Please test it and let me know if there's something missing.
I guess we can release the official next version sometime next week if nothing changes

I couldn't create the prebuilt wheels for Windows, I had trouble using Appveyor so any help with that is appreciated :)

We still need access to python-xmlsec official pypi (https://pypi.org/project/xmlsec/). @bgaifullin, @hoefling, @mehcode Can you add me as a maintainer so I can upload the new release.

  • 👍2
  • 🎉5
mxamin commented

@bgaifullin @hoefling @mehcode Any update regarding the access to pypi?

  • 😕1
vacarme commented

the pre-release fixes the installation issue using pip on macOs 14.4 M1 👍

  • 👍2
jimjag commented

Just a FYI that I'll be traveling from Apr15->May1 with limited 'net access

mxamin commented

Just a FYI that I'll be traveling from Apr15->May1 with limited 'net access

I'm also gonna be unavailable from 19th April -> 11th May. I'm trying to gain access to pypi so we can release the new version sooner but unfortunately none of the maintainers are responding. I even emailed them yesterday but no response yet.
XMLSec1 release the new version 1.3.4 two days ago, so we can release if we gain access.
Let's hope we gain access till then.

bgaifullin commented

Sorry for delay.

bgaifullin commented

Send invitation to mxamin and jimjag
Please check your mailbox.

  • 🎉4
mxamin commented

Send invitation to mxamin and jimjag Please check your mailbox.

Thanks a lot @bgaifullin

oussjarrousse commented

white smoke?

mxamin commented

Update: I'm working on preparing windows wheels, I hope I can finish it by the end of this week. If so we will release the new version.

  • 🎉5
mxamin commented

I released the new version: 1.3.14

  • 🎉11
  • 😕1