xmolecules/jmolecules

`ValueObject` interface for KMolecules

NathanCAllen opened this issue · 7 comments

NathanCAllen commented

Since #51 was implemented before #55, ValueObject was never added as an interface in KMolecules.

I'd create the PR for this myself, but I don't have write access to the repo.

denniseffing commented

I created a PR for this issue as I just stumbled upon this as well.

#101

@NathanCAllen You don't need write access to a repository to create a PR, you can fork the repository, push your changes on a branch and then open up a PR in the original repository.

odrotbohm commented

That's merged, thanks!

  • 👍1
mstine commented

Possible to get a release containing this fix quickly? I'm unfortunately unable to pull external snapshot dependencies.

odrotbohm commented

Kotlin? Have you switched to the dark side, Matt? 😜 I can wrap up a release tomorrow (Friday).

mstine commented

Kotlin is the dark side? 😂 At first glance I thought you were teasing me about my snapshots policy. At any rate, I've been writing pretty much 100% Kotlin since mid-2020. Oops.

Also, thanks! I've been following JMolecules from afar for awhile, but I'm finally getting a chance to use it!

odrotbohm commented

No package scope -> dark side. A hill I am wiling to die on. 😬

mstine commented

You're not wrong. I don't like it either. But cost/benefit to me has worked out pretty well.