xmudrii/etcdproxy-controller

Tighten newReplicaSet and newService functions to a private helper

Closed this issue · 0 comments

Comment by @deads2k on #2:

optional recommendation: I would tighten this function to a private helper that takes explicit args for its points of variability. That way any change will force compile-time errors through your code instead of silent and weird failures.