xnimorz/masked-input

Warning: componentWillReceiveProps

Closed this issue · 4 comments

boycce commented

Hi, thanks for the component 👍

Currently i'm receiving this error with "react": "^16.13.1"

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
  • Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: MaskInput

xnimorz commented

Hi @boycce!

Thank you for the issue!
I think it would be better to change the component from classes to function with hooks.
I'll change it several weeks later when I get some free time.

  • 🎉2
xnimorz commented

Hey @boycce !
Here is a commit, which should solve this issue: ff1f973

I'll test the component and publish the release in several days.

xnimorz commented

Hi @boycce
Fixed and published with react-maskinput@3.1.0

xnimorz commented

Hi @boycce
I'll close the issue as it seems to be resolved.
Feel free to reopen it or make another one in case you have any question :)