xofred/deviantart-gallery-downloader

Broken?

Closed this issue · 25 comments

The generated credentials are brand new. I can log in thru the browser using them just fine (I'm unable to test them in other software such as 4pr0n/ripme due to changes in DA's website (see 4pr0n/ripme#425); I'm not sure if perhaps this issue is caused by the same changes?

[efreak:~/source/deviantart-gallery-downloader] master 17s 1 ± ruby fetch.rb -n http://starkiteckt.deviantart.com/gallery/
Using netrc's credential
Connecting to deviantART
Logging in
undefined method `username=' for nil:NilClass
will retry after 1 second
undefined method `username=' for nil:NilClass
will retry after 1 second
undefined method `username=' for nil:NilClass
will retry after 1 second
undefined method `username=' for nil:NilClass
login failed after 3 retries
You might not be able to fetch the age restricted resources
Connecting to gallery
/home/efreak/source/deviantart-gallery-downloader/lib/deviantart_gallery_downloader.rb:24:in `fetch': undefined method `[]' for nil:NilClass (NoMethodError)
        from fetch.rb:3:in `<main>'

Fixed, plz pull the newest master branch and try again...

Hello, I cloned the latest master and it still returns the same error.

Using netrc's credential
Connecting to deviantART
Logging in
Log on successful
Connecting to gallery
/home/nonamethanks/tools/deviantart-gallery-downloader/lib/deviantart_gallery_downloader.rb:23:in `fetch': undefined method `[]' for nil:NilClass (NoMethodError)
	from fetch.rb:3:in `<main>'

If possible, may you provide the gallery link? Maybe pagination selector is not suited for every gallery...

I've tried http://oevrlord.deviantart.com/gallery/, it works. Remember to use GALLERY's PAGE, not author's page...

@nonamethanks Is it ok now? If everything is find, I would like to close this issue.

Yes, if I use the /gallery/ url it works @xofred

Glad to hear it!

Requesting re-open.

I purged the install of this script, still not working.
Purged my Gems install, still not working.

ruby fetch.rb -n http://alexandrab24.deviantart.com/gallery/?catpath=/

Using netrc's credential
Logging in
Log on successful
Connecting to gallery
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
failed to connect to gallery after 3 retries, abort

Please try ruby fetch.rb -n http://alexandrab24.deviantart.com/gallery/ instead @vxbinaca

Same result.

2017-03-14 3 16 29
It has to be gallery's page such as http://alexandrab24.deviantart.com/gallery/, not http://alexandrab24.deviantart.com/ or anything else. @vxbinaca

I ran the same command you did and got the same error.

@vxbinaca Could you provide the detailed error message, such as error line of code?

@xofred ptrace? That's the output I got:

ruby fetch.rb -n "http://megasweet.deviantart.com/gallery/"

Logging in
Log on successful
Connecting to gallery
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
failed to connect to gallery after 3 retries, abort

@vxbinaca Plz check out dev branch, it may solve the issue. And it can provide more error messages if not.

I was having the same issue on my debian system, and the dev branch fixed it.

EDIT: It's only fetching the first page (usually around 22 or so) then it thinks it's done. With or without the "/?catpath=/"

Tested on 4 different user's galleries, same results.

Without it. If it still not work, Could you provide the gallery link for me to debug? @1n5aN1aC

Well, something like ruby fetch.rb USERNAME PASSWORD http://sangrde.deviantart.com/gallery/ begins to download, but starts at 1/22, and once it reaches 22/22, it just says "all downloads completed."

I've tried it on 3 other artists' galleries as well, and all of them I've tried so far, either with personal credential, or with -n seem to do the same thing.

Turns out to be an account setting issue. Please go to https://www.deviantart.com/settings/browsing. In "General Browsing" section, make sure "Display" as "24 Thumbnails per Page" and "Paging" as "Click through pages"
2017-06-19 11 36 58

Ahh, so "scroll through pages" isn't compatible. Makes sense, even if it is disappointing.

I'd suggest you add that tidbit to a FAQ somewhere, but it's solved for me!

Good point, README updated.

Requesting a re-open this has cropped back up, or the open issue might possibly be a fix. Why he diff'd instead of a PR is beyond me.

Sadly, can confirm. As of maybe a little over a week ago, even the dev branch is broken again.
Will provide output text / more information in a couple hours, assuming I don't forget.